From a05e7fcf638dd6fff64b0ac2f53c63eede8b8f01 Mon Sep 17 00:00:00 2001 From: Julian Krauser Date: Wed, 9 Apr 2025 20:07:56 +0200 Subject: [PATCH 1/2] fix: prevent print all by empty ids array --- src/helpers/newsletterHelper.ts | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/helpers/newsletterHelper.ts b/src/helpers/newsletterHelper.ts index 5726dbd..267f282 100644 --- a/src/helpers/newsletterHelper.ts +++ b/src/helpers/newsletterHelper.ts @@ -140,9 +140,12 @@ export abstract class NewsletterHelper { } } - let members = await MemberService.getAll({ noLimit: true, ids: queryMemberIds }); - - return members[0]; + if (queryMemberIds.length == 0) { + return []; + } else { + let members = await MemberService.getAll({ noLimit: true, ids: queryMemberIds }); + return members[0]; + } } public static getICSFilePath(newsletter: newsletter) { From 43f397f0e2487e22d6bce6735b4ccd61358b17af Mon Sep 17 00:00:00 2001 From: Julian Krauser Date: Wed, 9 Apr 2025 20:08:19 +0200 Subject: [PATCH 2/2] fix: prevent whitespace in printout filename --- src/helpers/newsletterHelper.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/helpers/newsletterHelper.ts b/src/helpers/newsletterHelper.ts index 267f282..8ab1b05 100644 --- a/src/helpers/newsletterHelper.ts +++ b/src/helpers/newsletterHelper.ts @@ -268,7 +268,7 @@ export abstract class NewsletterHelper { await PdfExport.renderFile({ template: "newsletter", title: `Newsletter von ${CLUB_NAME}`, - filename: `${rec.lastname}_${rec.firstname}_${rec.id}`, + filename: `${rec.lastname}_${rec.firstname}_${rec.id}`.replace(" ", "-"), folder: `newsletter/${newsletter.id}_${newsletter.title.replace(" ", "")}`, data: data, })