fix: prevent whitespace in printout filename

fix: prevent print all by empty ids array
2025-04-09 20:08:19 +02:00 · 2025-04-09 20:07:56 +02:00
1 changed files with 7 additions and 4 deletions
--- a/src/helpers/newsletterHelper.ts
+++ b/src/helpers/newsletterHelper.ts
@ -140,9 +140,12 @@ export abstract class NewsletterHelper {
      }
    }

-    let members = await MemberService.getAll({ noLimit: true, ids: queryMemberIds });
-
-    return members[0];
+    if (queryMemberIds.length == 0) {
+      return [];
+    } else {
+      let members = await MemberService.getAll({ noLimit: true, ids: queryMemberIds });
+      return members[0];
+    }
  }

  public static getICSFilePath(newsletter: newsletter) {
@ -265,7 +268,7 @@ export abstract class NewsletterHelper {
      await PdfExport.renderFile({
        template: "newsletter",
        title: `Newsletter von ${CLUB_NAME}`,
-        filename: `${rec.lastname}_${rec.firstname}_${rec.id}`,
+        filename: `${rec.lastname}_${rec.firstname}_${rec.id}`.replace(" ", "-"),
        folder: `newsletter/${newsletter.id}_${newsletter.title.replace(" ", "")}`,
        data: data,
      })
Author	SHA1	Message	Date
Julian Krauser	43f397f0e2	fix: prevent whitespace in printout filename	2025-04-09 20:08:19 +02:00
Julian Krauser	a05e7fcf63	fix: prevent print all by empty ids array	2025-04-09 20:07:56 +02:00